Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/31073 ) Change subject: Increased the size of the FIFO/RIFO to 1600 frames (instead of 800) and changed the RIFO tests in such a manner that they do not hardcode the FIFO/RIFO size. ...................................................................... Patch Set 1: (6 comments) File tests/rifo/rifo_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/3ab315ab_729e15fd PS1, Line 18: (((int) (depth)) - (FRAMES_PER_FIFO - 1))) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/1ce9c4f8_b8aea8ee PS1, Line 18: (((int) (depth)) - (FRAMES_PER_FIFO - 1))) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/5d539fe1_9ab164fa PS1, Line 18: (((int) (depth)) - (FRAMES_PER_FIFO - 1))) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/6bf6201c_8bdeb960 PS1, Line 20: ("FRAMES_PER_FIFO - 1 + ")) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/481811d6_bfe652be PS1, Line 20: ("FRAMES_PER_FIFO - 1 + ")) please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3019): https://gerrit.osmocom.org/c/osmo-e1d/+/31073/comment/8c45f9db_aa0a1e2f PS1, Line 20: ("FRAMES_PER_FIFO - 1 + ")) please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/31073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Iebfe10aaf5244901c6ac0f4f84ac75e7947b57b8 Gerrit-Change-Number: 31073 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Lauter <christoph.lauter@christoph-lauter.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 25 Jan 2023 16:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment