Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31973 ) Change subject: library: L1CTL: merge L1ctl{Ul,Dl}Message into L1ctlMessage ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1:
Maybe it would be great to have a union in L1CTLMessage separating between messages in one direction […] I think this would complicate the API, so I prefer having them all in one union.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1313068c5f02b65d3dbb05a1341a9d7286225f0c Gerrit-Change-Number: 31973 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 21 Mar 2023 20:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment