Change in osmo-cbc[master]: sbcap: Log info about messages received and trasmitted

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 ) Change subject: sbcap: Log info about messages received and trasmitted ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/12db3bfe_4af0829b PS2, Line 8: it's about a hint to me where i can account the review work to File src/sbcap/sbcap_common.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/f96f757d_038eb039 PS2, Line 162: static char pdu_name[256] = "<unknown>"; hmm. a while back my impression was that we consciously decided to avoid static buffers, because over the years they build up, amounting to a lot of memory being hogged, completely unused for the vast majority of runtime. Ever since that decision i've been going out of my way to avoid static buffers There are functional benefits to talloc strings; in addition to the ones i posted before, a talloc string will never cut short a string because the static buffer is too small; i.e. we don't need to pick a size that the largest possible string might ever need. Since my attention was brought to this aspect, my opinion is that static buffers should be avoided. they are bad in various ways. this patch is already merged but i consider this still an open issue you brushed over -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 3 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Sat, 30 Jul 2022 19:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment