Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/6a243d59_09005e... : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) This is IMHO wrong: The asp_down should not have a specific AS being passed. Because the ASP state only changes independently of ASs. Hence, remove the "as" param here, and in tcap_cleanup_state(), change the logic to iterare over all ASs of an ASP when the param as=NULL is passed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:18:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No