laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42030?usp=email ) Change subject: cosmetic: xua_as_fsm.c: Improve spec documentation ...................................................................... cosmetic: xua_as_fsm.c: Improve spec documentation The specific spec paragraph talks about "Alternate ASP_Active" scenario in quotes, which I could find right away by grepping in the code. Improve the documentation so it can be easily matched in code. Change-Id: I79f5123d87dab79620657c2a2ebfd9fe22f178c3 --- M src/xua_as_fsm.c 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index fd44e70..092db55 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -310,8 +310,10 @@ return false; } -/* Tell other previously-active ASPs that a new ASP has been activated and mark - them as inactive. Used in override mode when an ASP becomes active. */ +/* RFC4666 4.3.4.3 "Alternate ASP_Active": + * Tell other previously-active ASPs that a new ASP has been activated and mark + * them as inactive. Used in override mode when an ASP becomes active." + * */ static void notify_any_other_active_asp_as_inactive(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp_cmp) { unsigned int i; @@ -612,7 +614,7 @@ break; case XUA_ASPAS_ASP_ACTIVE_IND: asp = data; - /* RFC466 sec 4.3.4.3 ASP Active Procedures*/ + /* RFC466 sec 4.3.4.3 ASP Active Procedures */ if (xafp->as->cfg.mode == OSMO_SS7_AS_TMOD_OVERRIDE) notify_any_other_active_asp_as_inactive(xafp->as, asp); /* SG role: No need to send DUNA for unknown destinations here -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I79f5123d87dab79620657c2a2ebfd9fe22f178c3 Gerrit-Change-Number: 42030 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org>