Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27646 ) Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition ...................................................................... Patch Set 3: (2 comments) File include/osmocom/gsm/protocol/gsm_08_58.h: https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/ff5609dc_d41744b3 PS3, Line 388: RSL_IE_IPAC_RTP_PAYLOAD2 = 0xfc,
It is needed to have same syntax in all enums, with a separation between name and equal. […] Ok, fine then.
File src/gsm/rsl.c: https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/1ddafb2d_eeb5b33a PS3, Line 128: [RSL_IE_IPAC_SRTP_CONFIG] = { TLV_TYPE_TLV },
It's not unrelated, precisely having this line makes the new contrib/jenkins. […] Ok, but I still think fixing things and adding build verification checks are separate things.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id8a679ca43eb0fcc4882780e9a95ec21c7f51972 Gerrit-Change-Number: 27646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 12:14:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment