Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/f90af13e_f22ce9ad PS3, Line 23: gsmtap-sapi pdtch : gsmtap-sapi ptcch Question: if I have 'gsmtap-sapi pdtch' in my config file, does this enable all GPRS categories? Similarly, if I do 'no gsmtap-sapi pdtch' and then 'gsmtap-category gprs dl-ctrl', will I see only the dl-ctrl messages or nothing? Oh, there is also 'pacch'... Here is another proposal, hopefully making all my questions above void: gsmtap ... gsmtap-sapi tch/f gsmtap-sapi tch/h gsmtap-sapi pdch (enable-all|disable-all) gsmtap-sapi pdch (dl-dummy|dl-ctrl|...) This way it looks more logical to me, and somehow consistent. P.S. there is no SAPI in GSMTAP. P.P.S. This probably comes from osmo-bts-sysmo, where the L1 prims have SAPI field. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 11:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment