Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30743 ) Change subject: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation ...................................................................... Patch Set 8: (3 comments) File src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/c6939c90_80d72c04 PS8, Line 60: void l1ctl_rx_gprs_uldl_tbf_cfg_req(struct l1_model_ms *, struct msgb *msg); function definition argument 'struct l1_model_ms *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/1acbed58_97237a8a PS8, Line 61: void l1ctl_rx_gprs_ul_block_req(struct l1_model_ms *, struct msgb *msg); function definition argument 'struct l1_model_ms *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/233b4dd1_3512e22c PS8, Line 80: void l1ctl_tx_gprs_dl_block_ind(struct l1_model_ms *, const struct msgb *msg, function definition argument 'struct l1_model_ms *' should also have an identifier name -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f Gerrit-Change-Number: 30743 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 12:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment