Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email ) Change subject: mme: Take into account KSI update by Network ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File mme/MME_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/213b5838_9cc73... : PS1, Line 405: c_NAS_TSC_NATIVE_SEC_CTX
It's the default param value, but I prefer keeping it here so it explicitly shows what we are using […] Then there's a little sense in using the template here, you could do:
``` kset_id := { '000'B, c_NAS_TSC_NATIVE_SEC_CTX } ``` or even more explicit: ``` kset_id := { identifier := '000'B, tSC := c_NAS_TSC_NATIVE_SEC_CTX } ``` but this is all cosmetics and I am not blocking here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841/comment/2e66d9cc_a1f36... : PS1, Line 405: '000'B
'000'B, guess what, means 0, which is basically one of the 2^3-1 you can select to start with, and w […] Ok, I just thought it might be a special kind of value like '111'B.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65 Gerrit-Change-Number: 39841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 24 Mar 2025 15:16:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>