Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email )
Change subject: stp: Test TCAP routing with a different called address answering ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: +1 from me once stuff mentioned here (and expected-results-xml) are fixed.
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/0b7c1d2d_94623... : PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1) Can we use template (omit) alt_asp_idx := omit here please? And then: if (isvalue(alt_asp_idx)) ...
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/e446ab9f_c6d6c... : PS1, Line 385: The answer is sent from a different point code than the request dpc */ "is sent" here is a bit ambiguous. Sent from who to where? I'd better describe it: "is sent by the STP peer to the STP".