Attention is currently required from: neels, laforge, pespin, lynxis lazus.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 )
Change subject: Add support for multiple APN profiles for subscriber data
......................................................................
Patch Set 9:
(2 comments)
File include/osmocom/hlr/hlr_ps.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/6901c36c_8919a03f
PS9, Line 23: #pragma once
This file is never included anywhere.
Should also be added to noinst_HEADERS in Makefile.am
https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/91881f94_778b92bd
PS9, Line 32: struct {
Now sure if an anonymous struct as top level in a header file makes sense?
Die you want to make it struct pdp_profile and include it in struct hlr in hlr.h?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/32512
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f
Gerrit-Change-Number: 32512
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: daniel
dwillmann@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 17 May 2023 10:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
