Attention is currently required from: fixeria.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email )
Change subject: tests: move pySim-trace test and its data into a sub directory
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
How about using a shorter name, i.e. […]
I thought about this too, but we should not be too unspecific. Actually I like it that the directory has the full name of the program. This makes it very clear for what exactly the tests are. (However, we might skip the "_test" suffix though)
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37822?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c
Gerrit-Change-Number: 37822
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de