fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) ...................................................................... bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) We cannot see how uninitialized access is possible, but gcc v13.2.1 does complain about it. Let's work this around by assigning an invalid value, like trx_count_free_tfi() does. src/bts.cpp: In function 'int bts_tfi_find_free(const gprs_rlcmac_bts*, gprs_rlcmac_tbf_direction, uint8_t*, int8_t)': warning: 'tmp_first_tfi' may be used uninitialized [-Wmaybe-uninitialized] Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Fixes: OS#6190 --- M src/bts.cpp 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index 0950f7a..50c21a3 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -642,7 +642,7 @@ /* find a TFI that is unused on all PDCH */ for (trx = trx_from; trx <= trx_to; trx++) { - uint8_t tmp_first_tfi; + uint8_t tmp_first_tfi = 0xff; /* make gcc happy */ unsigned int tmp_cnt; tmp_cnt = trx_count_free_tfi(&bts->trx[trx], dir, &tmp_first_tfi); if (tmp_cnt > best_cnt) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34533?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb Gerrit-Change-Number: 34533 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged