laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email ) Change subject: asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK ...................................................................... asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK This will basically use the same code logic as ASPUP branch above, so document it here so that it is added in both places at the same time. Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a --- M src/xua_asp_fsm.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index b55500b..e285e18 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -231,6 +231,17 @@ case XUA_ASP_E_ASPSM_ASPUP_ACK: /* RFC3868 Ch. 3.5.2 */ xua->hdr = XUA_HDR(SUA_MSGC_ASPSM, SUA_ASPSM_UP_ACK); + /* Optional: ASP ID */ +#if 0 + /* TODO: RFC 4666 3.5.2: + * "The optional ASP Identifier parameter is specifically useful for IPSP + * communication. In that case, the IPSP answering the ASP Up message + * MAY include its own ASP Identifier value." */ + if (ss7_asp_peer_requires_asp_id(asp)) { /* Maybe configure in VTY "asp" node? */ + asp_id = /* get a unique id of asp within as, eg. the index in as->asps[] */; + xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp_id); + } +#endif /* Optional: Info String */ break; case XUA_ASP_E_ASPSM_ASPDN: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a Gerrit-Change-Number: 40007 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de>