Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email ) Change subject: Allow io_uring_submit batching just ahead of poll/select ...................................................................... Patch Set 4: (4 comments) Patchset: PS3:
I'm still not convinced we want to add more envvars. […] Right now I use the envvars for running TTCN3 tests with different io_uring features. It makes it easier to compare.
File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/889cdea7_e7f90d3f?u... : PS2, Line 186: if (!g_io_uring_batch)
maybe use the OSMO_LIKELY macro for branch prediction optimizaton, as we assume the default is the c […] Done
https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/afbdc520_829fc90e?u... : PS2, Line 329: if (!g_io_uring_batch)
same here and further below Done
File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/a9058573_f6aff482?u... : PS3, Line 440: osmo_io_uring_submit();
I'd say it makes more sense to have the OSMO_UNLIKELY if here directly, to avoid an extra call+ret o […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc Gerrit-Change-Number: 40489 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 10:46:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de>