Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence ...................................................................... Patch Set 3: (1 comment) File src/fmt_rtp_efr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/ec56af19_a7992598 PS2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN))
is EFR_LEN garanteed to be == src_len here? Did you verify this already? maybe add an OSMO_ASSERT(src_len == EFR_LEN)?
-- To view, visit https://gerrit.osmocom.org/c/gapk/+/32094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093 Gerrit-Change-Number: 32094 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: matanp <matan1008@gmail.com> Gerrit-Comment-Date: Tue, 28 Mar 2023 13:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment