Attention is currently required from: laforge, manawyrm.
pespin has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43643?usp=email )
Change subject: octoi: rework frame_rifo logic to decompress frames on the output side ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/8ccd5de0_913b4235?usp=... : PS5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME); any reason to do the zeroing further up now?
File src/octoi/octoi.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/b1a7ede1_5a501e9a?usp=... : PS5, Line 140: /* substitute with last received frame */ No substitution now afaict?