Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33947 ) Change subject: llc: Introduce function to log XID fields and use upon Rx/Tx ...................................................................... Patch Set 3: (1 comment) File src/llc/llc_xid.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33947/comment/a76ea39d_61db66a5 PS3, Line 325: void gprs_llc_dump_xid_fields(const struct gprs_llc_xid_field *xid_fields, I think it would be better to have some kind of visual begin + end marker in the log, to clearly see at one point where one LLC message starts and ends. One possible option is to have indenting (either fixed or caller-specified). A caller-specified "const char *prefix" prepended to every string covers that case, and also allows to specify further context (like the subscriber, if we ever move the SGSN over to this lib). -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8c6b07305c0bcecb4e1681967884a3e62c813592 Gerrit-Change-Number: 33947 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 27 Jul 2023 06:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment