Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 ) Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/55004c17_3a0e5a67 PS1, Line 17: entire SCCP conn id number space before exiting in failure.
I don't think it should be configurable. […] In some programs we have sanity counters to limit iterations to find an unused ID, I think like 1000 or 10000 or some such, so I thought it might be a good idea. AFAICT not for SCCP though, more the other protocols...
I've been hitting this issue of finding an unused ID a lot, and it is in theory a pretty hard problem to make this always O(1). But I've been thinking on-and-off about a general API that will in "all" practical situations be O(1), completely avoiding a lookup whether an ID is used. So yes, ok, if the way to find an unused ID changes and does not require a max_iterations argument at all, then you're probably right and we shouldn't put that parameter there at all. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ib64e0cb1ae0cc8b7bebcb2a352d4068b496b304a Gerrit-Change-Number: 32320 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 00:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment