Attention is currently required from: osmith, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex representations in cmd numeric ranges ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/57f8c1e6_a9d33a59 PS6, Line 9: in hexadecimal range
I would say: "... using hexadecimal notation". Not critical. Done
File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/435f2f6a_7e3c355c PS6, Line 1487: error
s/error/a negative value/ Done
https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/8f5e7fe1_e5be9677 PS6, Line 1505: if (isdigit(*ptr) ||
Nice I didn't know about that one. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 16 Sep 2022 20:21:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment