Attention is currently required from: Hoernchen, fixeria, laforge, manawyrm. Hello Hoernchen, Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned ...................................................................... Transceiver52M: fix viterbi-eq soft bits on platforms where char is unsigned The viterbi-eq demodulator stores soft bits into chars. "char" is signed on x86/amd64 but unsigned on arm64. On arm64 the stored byte 0x81 (== -127) is read back as +129, so after the sign flip and vectorSlicer() clamp every soft bit collapses to 0.0. The same issue also appears to be present in the MS code path, so it was (blindly) fixed there as well. The MS fixes are untested! Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.cpp M Transceiver52M/grgsm_vitac/grgsm_vitac.h M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp M Transceiver52M/ms/ms_upper.h M utils/va-test/burst-gen.cpp 7 files changed, 36 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/22/42822/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1cda66228f3d48e1b941b25614d599c16ad79aa0 Gerrit-Change-Number: 42822 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account@tbspace.de> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account@tbspace.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>