Attention is currently required from: laforge. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33201 ) Change subject: stream: Add IPA send function, pull IPA headers in segm. cb ...................................................................... Patch Set 11: (4 comments) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/905a1e1f_083b5060 PS10, Line 475: void ipa_stream_srv_send
looks like this is this a new public function without osmo_ prefix? ah yes I wondered about this shortly... saw the `ipaccess_send_*` functions before & did something similar to that naming scheme
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/d6b365fc_16bbf9fa PS10, Line 494: void ipa_stream_cli_send(struct osmo_stream_cli *cli, int ipaccess_proto,
looks like this is this a new public function without osmo_ prefix? Done
File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/92dbdec1_2a8334a5 PS1, Line 632: SRV
The idea was to name the macro after the use-case it was designed for, since in all (or at least a l […] Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/7869ad22_829e96a1 PS1, Line 1952: from the msgb structure's l1 and possibly l2 headers
Iirc, the agreement had been to have the IPA read callback pull the headers from the message, but pr […] IPA proto/proto ext information is now stored in `msgb->cb`
-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 33201 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Sun, 09 Jul 2023 21:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment