Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33256 ) Change subject: Added generation of include/osmocom/core/socket_compat.h ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmocom/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/33256/comment/f51e05fd_a820308c PS1, Line 98: socket_compat.h.tpl
this likely needs to go into EXTRA_DIST or something along those lines. […] Done
File include/osmocom/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/33256/comment/4c4d3ba0_69ce4864 PS2, Line 102: EXTRA_DIST = socket_compat.h.tpl
we usually put this above, around line 83 Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia3eafc992221900bbbf1760f669725bf9da92105 Gerrit-Change-Number: 33256 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 15:06:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment