Attention is currently required from: neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 5: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/9b4592a5_f1231a9f?usp=... : PS5, Line 9: The VLR must be allowed to notify the MSC if an subscriber becomes invalid.
a subscriber Done
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/ace03b52_c41d61f8?usp=... : PS5, Line 10: There are multiple cases when this happens:
(maybe a good idea too add this very useful list in the api doc comment for the callback) Done
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/4396518e_7dbe7fb4?usp=... : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw
does Done
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/547fb219_a2cce661?usp=... : PS5, Line 13: b) if the HLR do a Cancel Location Procedure with reason withdraw @neels I'm a little bit unsure, if the MSC informs the user. So far there isn't a IMSI detach by the network. You could do a paging, but why should you do it? This would increase the traffic for a subscriber which shouldn't get any further service. If you do paging, what do you send? A MM Status with reason 33 (Requested service option not subscribed)? So if you don't page, the MS will do a Location update Request or Service Request at some point which can be rejected (guess with the same code?). https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/c677a83c_032a8a97?usp=... : PS5, Line 14: c) if the HLR do a Cancel Location Procedure with reason update location.
does Done
https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/e9839180_8840abe3?usp=... : PS5, Line 17: For c) the MSC must inform the MS about the reason.
This line is wrong. For c) the MSC doesn't inform the MS about the reason, it is already gone. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 23:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>