Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32023 ) Change subject: gsm_04_08: document/clarify enum gsm48_chan_mode values ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/32023/comment/1a91ecc5_967a58b5 PS1, Line 775: /*! Speech: FR AMR-WB, in VAMOS mode */
This is being fixed in the followup commit, I think you got it wrong and it belongs here. No, I intentionally did not reference `GSM48_CMODE_SPEECH_V5` in this commit because it's not yet defined. The upcoming change adds it, so I update the reference there.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I716027f73ab6f20037f6de16e4a3740811aa38a2 Gerrit-Change-Number: 32023 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 11:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment