Attention is currently required from: jolly. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email ) Change subject: Add command and client function to change transmitted Sa bits ...................................................................... Patch Set 3: (1 comment) File src/proto_clnt.c: https://gerrit.osmocom.org/c/osmo-e1d/+/35562/comment/dae4ff1b_579852b2 PS3, Line 420: if (msgb_l2len(msgb) != sizeof(struct osmo_e1dp_line_info)) This looks like a cut and paste error. The command doesn't return a osmo_e1dp_line_info. It returns no data, so size of l2 should be 0. Also I've just noticed that in that error handling path (which we use in other places above), we leak the msgb. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I2608af7bbb8092fddd68d4f3bb36b10a1100ce0f Gerrit-Change-Number: 35562 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Tue, 16 Jan 2024 07:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment