24 May
2023
24 May
'23
7:19 p.m.
Attention is currently required from: jolly.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 )
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008 ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: I find it weird that all functions `assert()` all their pointer arguments. Looks overdefensive. Other than that, the patch looks good to me.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 4
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Comment-Date: Wed, 24 May 2023 17:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment