Attention is currently required from: jolly, laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email )
Change subject: rspro_util: asn1 decode: fix memleak when decoding fails
......................................................................
Patch Set 1:
(1 comment)
File src/rspro_util.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/0b5f1f93_7611eb8f?u... :
PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu);
Acknowledged
For another commit: I would move the ownership into the function and not only for the success cases.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27
Gerrit-Change-Number: 42705
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Mon, 27 Apr 2026 16:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu