6 Apr
2026
6 Apr
'26
6:29 p.m.
Attention is currently required from: canghaiwuhen, laforge, pespin.
fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )
Change subject: gprs_sm: gsm48_tx_gsm_act_pdp_acc(): fix QoS profile length ......................................................................
Patch Set 19:
(1 comment)
File src/sgsn/gprs_sm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/28dc1c77_3edc6b75?usp... : PS5, Line 209: //msgb_lv_put(msg, sizeof(default_qos), (uint8_t *)&default_qos);
This line can be removed, since you are replacing it.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c
Gerrit-Change-Number: 42050
Gerrit-PatchSet: 19
Gerrit-Owner: canghaiwuhen canghaiwuhen@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: canghaiwuhen canghaiwuhen@gmail.com
Gerrit-Comment-Date: Mon, 06 Apr 2026 16:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de