Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31848 ) Change subject: virt_phy: rearrange and clean up header files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:
What's the point of nesting it under /bb/ - it stands for baseband and virt_phy has nothing to do wi […] Well, the project name is `osmocom-bb`. If you take a look at the other `[lib]osmo-$PROJECT` repositories, you'll see it's a common practice to have the root hierarchy in `include/osmocom/$PROJECT`. Given that osmocom-bb is special in a way that it's actually several related projects in one repository, I believe it's necessary to have another layer `include/osmocom/$PROJECT/$SUBPROJECT`.
Following your logic, virt_phy should not be part of this repository because it has nothing to do with the baseband, like many other sub-projects too. So I disagree and I think it's fine. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25145630ec53c2b8065a42fb12a778eec010f10c Gerrit-Change-Number: 31848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev@sysmocom.de> Gerrit-MessageType: comment