Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Patch Set 3: (1 comment) File ccid_common/iso7816_fsm.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/e71c3ffc_c16... : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
yes, really interesting, i wonder why that is? interestingly I rarely see any other developer even s […] I've seen quite a number of cases where cosmetich changes were submitted separately from functional changes.
of course you won't find instances of someone running some automatic formatting tool in one cosmetic commit and then submitting another functional commit on top of that, as we do not have any tradition of using automatic formatting tools in Osmocom. I thought with osmo-ccid-firmware we can give you a shot at trying that approach, but what I've seen so far here is doing anything but convince me that this is something we want to do or possibly even expand to other repositories. I'm willing to let the experiment run for some more time and would actually like to see it succeed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 14:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org>