Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email )
Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ......................................................................
Patch Set 9:
(6 comments)
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/0dce9a4b_20551e7e?usp... : PS9, Line 908: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f23d9e82_80079b71?usp... : PS9, Line 913: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/b7afda9c_c53955dc?usp... : PS9, Line 913: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ce622616_a56d6ce1?usp... : PS9, Line 1120: if (buf_len <= 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a3bfb616_4d487bb1?usp... : PS9, Line 1134: // break; please, no space before tabs
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/9f338205_8e14079e?usp... : PS9, Line 1373: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()