laforge has submitted this change. ( https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713 ) Change subject: Fix message type of UPLINK SEIZED COMMAND ...................................................................... Fix message type of UPLINK SEIZED COMMAND The UPLINK SEIZED COMMAND, as defines in "type record PDU_BSSMAP_UplinkSeizedCommand" has wrong message type. It is '4E'O, but it must be '4D'O. I verified it against the TS 48.008. 4E'O is used for CHANGE CIRCUIT message. Related: OS#6087 Change-Id: I61ff2532a4d6eb3aa1ed96cdeb1f2c848ef4447e --- M src/BSSAP_Types.ttcn 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/src/BSSAP_Types.ttcn b/src/BSSAP_Types.ttcn index 7b9592e..70c10e1 100644 --- a/src/BSSAP_Types.ttcn +++ b/src/BSSAP_Types.ttcn @@ -2612,12 +2612,12 @@ // UPLINK SEIZED COMMAND- 48.008 subclause 3.2.1.63 type record PDU_BSSMAP_UplinkSeizedCommand { - OCT1 messageType, // H'4E + OCT1 messageType, // H'4D BSSMAP_IE_Cause cause, BSSMAP_IE_TalkerPriority talkerPriority optional, BSSMAP_IE_EmergencySetIndication emergencySetIndication optional, BSSMAP_IE_TalkerIdentity talkerIdentity optional -} with { variant "PRESENCE (messageType = '4E'O)" } +} with { variant "PRESENCE (messageType = '4D'O)" } -- To view, visit https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: titan.ProtocolModules.BSSMAP Gerrit-Branch: master Gerrit-Change-Id: I61ff2532a4d6eb3aa1ed96cdeb1f2c848ef4447e Gerrit-Change-Number: 33713 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged