Attention is currently required from: biocape.
dexter has posted comments on this change by biocape. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email )
Change subject: Add GSM 7-bit packing and Network Name IE support
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Interesting usecase for python's unbound integer type - I like that.
File src/osmocom/utils.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/43371/comment/a75d31a9_50786... :
PS1, Line 121: int.from_bytes(packed, byteorder='little')
I like the approach, but there is a problem here: `int. […]
Just wondering, it should not matter if 0x01 or 0x00 is appended, correct?
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I4661352e39031dc0041fc7851f675d6083a1035f
Gerrit-Change-Number: 43371
Gerrit-PatchSet: 1
Gerrit-Owner: biocape
biofel@cape.co
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: biocape
biofel@cape.co
Gerrit-Comment-Date: Mon, 21 Sep 2026 15:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de