Attention is currently required from: osmith, fixeria, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 ) Change subject: gbprox_rx_ptp_from_bss: fix dangling pointer ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I don't think this is the correct solution. tp is used inside the call(s) to osmo_fsm_inst_dispatch() directly and not needed outside of this function. This pattern also exists in other functions: gbprox_rx_{sig,ptp}_from_{bss,sgsn} Maybe it helps to set msgb_bcid() to 0 before returning from these functions? Also, I'm not able to reproduce this with "gcc version 12.3.0 (Debian 12.3.0-6)" ``` gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I.. -fsanitize=address -fsanitize=undefined -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -Wall -Wno-trigraphs -Wall -fno-strict-aliasing -I/home/daniel/local/osmo-master/include/ -pthread -I/home/daniel/local/osmo-master/include/ -pthread -I/home/daniel/local/osmo-master/include/ -pthread -I/home/daniel/local/osmo-master/include/ -pthread -I/home/daniel/local/osmo-master/include/ -fno-strict-aliasing -pthread -ggdb3 -Og -fno-omit-frame-pointer -std=gnu11 -fsanitize=address -fsanitize=undefined -Werror -Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp -Wall -Wno-trigraphs -MT gb_proxy.o -MD -MP -MF .deps/gb_proxy.Tpo -c -o gb_proxy.o gb_proxy.c ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ie51e37572993cb5dc24ecf13bc300225f09cb744 Gerrit-Change-Number: 33738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 09:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment