Attention is currently required from: daniel, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 11: (6 comments) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/8463873f_6e6ee15c?usp... : PS11, Line 899: struct
Im surprised that the destination peer is not 'const'. […] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/a57376db_706b878f?usp... : PS11, Line 1134: int gtp_decode_pdp_ctx(const uint8_t *buf, unsigned int size, struct pdp_t *pdp, uint16_t *sapi)
I think the function could deserve some documentation as a comment [doxygen style or not] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/eddf1ca0_005a917d?usp... : PS11, Line 1273: int gtp_encode_pdp_ctx(uint8_t *buf, unsigned int size, const struct pdp_t *pdp, uint16_t sapi)
I think the function could deserve some documentation as a comment [doxygen style or not] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/108ae602_a0116865?usp... : PS11, Line 1403: LOGP(DLGTP, LOGL_NOTICE,
shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with […] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2cf5f4bb_a9a10cea?usp... : PS11, Line 1410: "SGSN Context Response expected Sequence flag set. Flags %d\n", packet->flags);
shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with […] Done
https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/ee9b8d06_77d3c7d6?usp... : PS11, Line 1458: "SGSN Context Request expected only on GTPCv1: %u\n", version);
same here Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>