Attention is currently required from: dexter, fixeria, lynxis lazus.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43958?usp=email )
Change subject: gprs_sndcp_xid: replace OSMO_ASSERT with if and return ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
File src/sgsn/gprs_sndcp_xid.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/19ce2de6_fdf73681?usp... : PS1, Line 172: if (params->f_max_time < 1) You can put all these checks in one if line please.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/1eb106e6_38829ce1?usp... : PS1, Line 249: if (params->max_cid < 0) Same, all these checks in one line.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/3a7fbbd1_2f0c2579?usp... : PS1, Line 481: } else if possible add {} here while at it.
https://gerrit.osmocom.org/c/osmo-sgsn/+/43958/comment/94ca28c8_d54161a4?usp... : PS1, Line 641: byte_counter += TLV_GROSS_LEN(sizeof(xid_version_number)); This looks like belonging to one of your previous patches, not this one.