Attention is currently required from: osmith, fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33292 ) Change subject: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT ...................................................................... Patch Set 7: (3 comments) File src/common/asci.c: https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/ccf74bcd_651d5aa9 PS6, Line 79: is in not active
This looks weird, maybe just "is not active"? Done
https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/1be5c0b6_5e98b6b0 PS6, Line 154: v
c Done
File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/cae8919b_fc906312 PS6, Line 1988: handover
Change to "DCCH"? The function actually expects a channel type name, not type of access. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bd07ab6802341b09a06e89df356665ffaf6d2bf Gerrit-Change-Number: 33292 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment