8 Oct
2026
8 Oct
'26
3:46 p.m.
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43516?usp=email )
Change subject: saip/batch: add blacklist to to_csv_rows() ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File pySim/esim/saip/batch.py:
https://gerrit.osmocom.org/c/pysim/+/43516/comment/b111ecd1_9cd90621?usp=ema... : PS2, Line 328: """generator that yields all audits' values as rows, useful feed to a csv.writer.""" As far as I understand this method is supposed to be called by the API user. I would recommend to document each of the parameters.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24
Gerrit-Change-Number: 43516
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Oct 2026 13:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes