laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35700?usp=email ) Change subject: pco: Improve IPCP spec reference documentation ...................................................................... pco: Improve IPCP spec reference documentation Change-Id: I1dd4a41bae491c61197e8e307efcfc8c63945a71 --- M ggsn/pco.c M ggsn/pco.h 2 files changed, 14 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn/pco.c b/ggsn/pco.c index e2181e1..c71f07d 100644 --- a/ggsn/pco.c +++ b/ggsn/pco.c @@ -110,6 +110,7 @@ osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length)); } +/* Handle IP Control Protocol, RFC 1332, extensions in RFC 1877 */ static void process_pco_element_ipcp(const struct pco_element *pco_elem, struct msgb *resp, const struct apn_ctx *apn, struct pdp_t *pdp) { diff --git a/ggsn/pco.h b/ggsn/pco.h index 4d999ef..2f95d09 100644 --- a/ggsn/pco.h +++ b/ggsn/pco.h @@ -42,12 +42,11 @@ uint8_t data[0]; } __attribute__((packed)); - -/* RFC 1332 */ +/* RFC 1332 IP Control Protocol options, extensions in RFC 1877 */ enum ipcp_options { - IPCP_OPT_IPADDR = 3, - IPCP_OPT_PRIMARY_DNS = 129, - IPCP_OPT_SECONDARY_DNS = 131, + IPCP_OPT_IPADDR = 3, /* RFC 1332 3.3 */ + IPCP_OPT_PRIMARY_DNS = 129, /* RFC 1877 1.1 */ + IPCP_OPT_SECONDARY_DNS = 131, /* RFC 1877 1.2 */ }; struct ipcp_option_hdr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1dd4a41bae491c61197e8e307efcfc8c63945a71 Gerrit-Change-Number: 35700 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-MessageType: merged