Attention is currently required from: bucketking657. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sgsn_libgtp: encode IMEISV via a local LV buffer ...................................................................... sgsn_libgtp: encode IMEISV via a local LV buffer gsm48_encode_bcd_number() was called on pdp->imeisv.v with max_len 8, which only worked because it compares max_len against the L octet. A 16-digit IMEISV needs 9 bytes (L plus 8 octets). Encode into a local 9-byte LV buffer, check the return code, and copy the value part. Related: OS#7126 Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c --- M src/sgsn/sgsn_libgtp.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/50/44150/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c Gerrit-Change-Number: 44150 Gerrit-PatchSet: 3 Gerrit-Owner: bucketking657 <joshuashilts@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: bucketking657 <joshuashilts@gmail.com>