7 Sep
2026
7 Sep
'26
11:35 a.m.
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43172?usp=email )
Change subject: GP: LOAD/STORE DATA chunk size from SCP overhead ......................................................................
Patch Set 7:
(1 comment)
File tests/unittests/test_globalplatform.py:
https://gerrit.osmocom.org/c/pysim/+/43172/comment/abe704f0_0a4e00da?usp=ema... : PS7, Line 385: # GP CardSpec v2.3.1 Section 11.8.2.3.1: all lengths ofPUT KEY are always BER TLV coded
missing space ("...length ofPUT KEY... […]
I would recommend to fix this typo, re-add +2 and then to merge this patch.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43172?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic208f3959a38896f64fb6ccefb24cc360a3ac3a2
Gerrit-Change-Number: 43172
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Comment-Date: Mon, 07 Sep 2026 09:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter pmaier@sysmocom.de