Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email )
Change subject: Add test case to verify proper DSCP settings ......................................................................
Patch Set 9: -Code-Review
(1 comment)
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/77fb50cb_c6b2fd... : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore])
I think it's fundamentally wrong to merge this as is since now afaiu make check needs osmo-python or […]
Ah, I agree. I didn't understand your earlier comment, which made me think like "why would this have to do anything with the existing vty tests" and not "this is a problem as it requires osmopy during make check".