Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42475?usp=email )
Change subject: pysim/pcsc: do not use getProtocol for protocol selection
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Agreed.
I have now added a comment. I have also checked pyscard manual again. There is no explicit suggestion or preferred way how to do deal with the protocol selection. I think the way we do it now is perfectly valid. The API even provides a setProtocol method, which I am using now. With that we do not have to close and re-open the connection.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/42475?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib119948aa68c430e42ac84daec8b9bd542db7963
Gerrit-Change-Number: 42475
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Mar 2026 13:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de