Attention is currently required from: fixeria, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email ) Change subject: build: make timerfd usage optional ...................................................................... Patch Set 3: (1 comment) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/598ef953_14dc2f92?usp=... : PS3, Line 56: #endif
so the code doesn't fail if this header is not included? why? is this header needed here? Right, the code builds fine without this header. None of the symbols from <sys/timerfd.h> are used in this file, so the include is not required. It was likely left over from earlier code or copied from somewhere else.
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a Gerrit-Change-Number: 42689 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 29 Apr 2026 20:14:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>