Attention is currently required from: fixeria.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41771?usp=email )
Change subject: generate sdkey classes from a list ......................................................................
Patch Set 9:
(2 comments)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/41771/comment/9cc22dc1_3bdc3d0a?usp=ema... : PS7, Line 653: reserved_kvn = tuple()
This is defined but never used anywhere?
I guess we can drop it then, cruft from an earlier patch version?
https://gerrit.osmocom.org/c/pysim/+/41771/comment/d6dc317d_985afb28?usp=ema... : PS7, Line 694: NO_OP = (('', {}))
Likewise, defined but not used.
we can drop it, this is definitely cruft from an earlier patch version.