fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43826?usp=email )
Change subject: trxcon/trx_if: fix stale doc comments on POWERON/RXTUNE/TXTUNE ......................................................................
trxcon/trx_if: fix stale doc comments on POWERON/RXTUNE/TXTUNE
These no longer match reality: osmo-trx-proxy and fake_trx.py both permit RXTUNE/TXTUNE regardless of power state, and POWERON is in fact rejected (not idempotent) if the transceiver is already on.
Change-Id: I9408ea573598459d47af957577dece883606caa8 --- M src/host/trxcon/src/trx_if.c 1 file changed, 4 insertions(+), 8 deletions(-)
Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve
diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c index fbc0fcd..17e3d62 100644 --- a/src/host/trxcon/src/trx_if.c +++ b/src/host/trxcon/src/trx_if.c @@ -196,9 +196,7 @@ * POWERON starts the transmitter and starts the demodulator. * Initial power level is very low. * This command fails if the transmitter and receiver are not yet tuned. - * This command fails if the transmit or receive frequency creates a conflict - * with another ARFCN that is already running. - * If the transceiver is already on, it response with success to this command. + * This command fails if the transceiver is already on. * CMD POWERON * RSP POWERON <status> */ @@ -253,11 +251,9 @@ /* * Tuning Control * - * (RX/TX)TUNE tunes the receiver to a given frequency in kHz. - * This command fails if the receiver is already running. - * (To re-tune you stop the radio, re-tune, and restart.) - * This command fails if the transmit or receive frequency - * creates a conflict with another ARFCN that is already running. + * RXTUNE/TXTUNE tune the transceiver to a given Rx/Tx frequency in kHz. + * Both osmo-trx-proxy and fake_trx.py permit this command regardless + * of the power state (before and after POWERON). * CMD (RX/TX)TUNE <kHz> * RSP (RX/TX)TUNE <status> <kHz> */