Attention is currently required from: bucketking657. pespin has posted comments on this change by bucketking657. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email ) Change subject: sgsn_libgtp: pass the real buffer size when encoding the IMEISV ...................................................................... Patch Set 1: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/44150/comment/297c120c_48ebc540?usp... : PS1, Line 306: gsm48_encode_bcd_number(&pdp->imeisv.v[0], 9, 0, mmctx->imei); This is all imho a bit clunky, since we are encoding LV into a buffer which expects to only have V, then move stuff around... I'd say better rework the whole "if" block to: * allocate a uint8_t bcd_lv[9] in the stack. * call gsm48_encode_bcd_number(bcd_lv, sizeof(bcd_lv),...) and check for return code for errors. * pdp->imeisv.l = bcd_lv[0]; memcpy(&pdp->imeisv.v[0], &bcd_lv[1], pdp->imeisv.l); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c Gerrit-Change-Number: 44150 Gerrit-PatchSet: 1 Gerrit-Owner: bucketking657 <joshuashilts@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: bucketking657 <joshuashilts@gmail.com> Gerrit-Comment-Date: Thu, 19 Nov 2026 17:33:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No