Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 1: (6 comments) File src/host/layer23/include/osmocom/bb/common/l23_app.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/4529ece9_8f92831f PS1, Line 22: L23_GSMTAP_C_DL_DUMMY = 1, /* downlink dummy blocks */ please, no space before tabs File src/host/layer23/src/common/vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/331e9bdf_187575f0 PS1, Line 150: { GSMTAP_CHANNEL_CBCH51,"CBCH" }, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/a34d2173_9f5d7bfa PS1, Line 470: "|",")", VTY_DO_LOWER); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/95b0e18f_d52e50f6 PS1, Line 477: "|",")", VTY_DO_LOWER); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/83471faa_9131d940 PS1, Line 485: "|",")", VTY_DO_LOWER); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3100): https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/691d2430_2b98d65e PS1, Line 491: "|",")", VTY_DO_LOWER); space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 30 Jan 2023 16:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment