laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email ) Change subject: cosmetic: Improve comment with spec ref in RACH Control Parameters ...................................................................... cosmetic: Improve comment with spec ref in RACH Control Parameters Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 35b3427..a919aae 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -634,13 +634,13 @@ #endif } __attribute__((packed)); -/* Chapter 10.5.2.29 */ +/* 3GPP TS 44.018 Chapter 10.5.2.29 "RACH Control Parameters" */ struct gsm48_rach_control { #if OSMO_IS_LITTLE_ENDIAN - uint8_t re :1, - cell_bar :1, - tx_integer :4, - max_trans :2; + uint8_t re :1, /* RE, Call reestablishment allowed */ + cell_bar :1, /* CELL_BAR_ACCESS */ + tx_integer :4, /* Tx-integer */ + max_trans :2; /* Max_Retrans */ uint8_t t2; /* ACC 8-15 barred flags */ uint8_t t3; /* ACC 0-7 barred flags */ #elif OSMO_IS_BIG_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org>